Fix ESM type import in Webpack loader #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript 5.3 introduced support for import attributes and `resolution-mode`. This can be used to import types from ESM files into CJS files without a `@ts-ignore` comment.
remcohaszing
added
🐛 type/bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ChristianMurphy
approved these changes
Mar 5, 2024
wooorm
approved these changes
Mar 6, 2024
wooorm
changed the title
wooorm
added
💪 phase/solved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
TypeScript 5.3 introduced support for import attributes and
resolution-mode. This can be used to import types from ESM files into CJS files without a@ts-ignorecomment.The
@ts-ignorecomment is stripped from generated type definitions, which leads to a type error for consumers. The module resolution mode is not, which fixes it for users using TypeScript 5.3 or greater.